rerun-io
Webviewer increasing memory does not work
Describe the bug When running rerun with either
- the CLI using "rerun --serve-web --server-memory-limit 5GB --memory-limit 5GB"
- the API using "rr.serve_grpc(server_memory_limit="5GB")"
- or "rr.spawn(recording=rec, connect=True, memory_limit="5GB%", server_memory_limit="5GB")"
Every time the viewer tells me it drops data reaching 2.3 GB. Later is discovered the memory pane is a quicker way to see the limit.
Using the native viewer, the memory-limit does change! (using the api and the cli)
To Reproduce
Start a webserver and look at the memory panel for me it shows a maximum of 2.3 GB no matter what I do
rerun --serve-web
_According to the manual this should result in:
memory-limit default: 75% (in my case 75% of 32 GB = 24 GB)
server-memory-limit default: 25% (8 GB)
rerun --serve-web --server-memory-limit 5GB --memory-limit 5GB
Does not change anything, the memory limit in the webviewer still shows as 2.3 GB
Using rerun --serve-grpc and then connecting using rerun --connect will show a native viewer with changed memory-limits
Expected behavior Changing the memory limit should change the actual limit
Desktop (please complete the following information):
- Windows 11 Enterprise Version10.0.22631 Build 22631
- System Model: HP ZBook Fury 16 G10 Mobile Workstation PC
- Processor: 13th Gen Intel(R) Core(TM) i7-13850HX, 2100 Mhz, 20 Core(s), 28 Logical Processor(s)
- Installed Physical Memory (RAM): 32,0 GB
Rerun version 0.26.2
As pointed out on Discord the WebViewer is a wasm32 process and can't support more than around 3.5gb for the memory limit. Not sure though if there's some bug in how we pass the limit on. If we intentionally don't then it should ofc at least warn!
... actually I it should warn for any memory limit that is not "physically" possible either way
Related discord thread https://discord.com/channels/1062300748202921994/1075873257124810852/1432998003769086063