rerun icon indicating copy to clipboard operation
rerun copied to clipboard

Examples: app_id should take into account active demo/recording/scene

Open teh-cmc opened this issue 2 years ago • 2 comments

What the title says.

  • Avoids a poor user experience where one ends up with a bunch of zombie space views
  • Provides interesting analytics for official examples

teh-cmc avatar Feb 07 '23 11:02 teh-cmc

went in!

Wumpf avatar Feb 15 '23 11:02 Wumpf

lies!

teh-cmc avatar Feb 15 '23 11:02 teh-cmc

I don't understand this issues.

What does "active demo/recording/scene" refer to? The currently open recording in the viewer?

When should app_id take it into account? When the example sets the app_it in init? In analytics?

emilk avatar Feb 28 '23 16:02 emilk

What does "active demo/recording/scene" refer to? The currently open recording in the viewer?

It refers to the application-specific notion of "what's the current dataset", e.g.:

  • For objectron, the app_id should change depending on the dataset being visualized (e.g. book vs bike)
  • For api_demo, the app_id should change depending on the --demo flag
  • etc

teh-cmc avatar Feb 28 '23 16:02 teh-cmc

I don't agree on the objectron example - it is the same application regardless of what you visualize, and you should expect to have the same blueprint regardless if you are "scanning" a book or a bike.

For api_demo: for this one I agree (though it is not really an example, and we should either turn it into many small examples or make it into a test)

emilk avatar Jun 12 '23 10:06 emilk