toolbelt icon indicating copy to clipboard operation
toolbelt copied to clipboard

SourceAddressAdapter with certain port should be stricter with pool size and blocking?

Open n1ngu opened this issue 1 year ago • 0 comments

As far as I understand, if SourceAddressAdapter is used with an (IP, PORT) tuple and the port is other than 0, there is no way this adapter can work without passing

pool_connections=1,
pool_maxsize=1,
pool_block=True,

to the underlying HTTPAdapter.

Shouldn't this either

  • be forced by the implementation
  • raise a warning if this exact values are not specified by the user
  • write more documentation about it

?

n1ngu avatar Jul 25 '22 13:07 n1ngu