requests-oauthlib
requests-oauthlib copied to clipboard
Mentions of "URI" should be "URL"
The acronym uri is used all over the place in code and documentation, where it should be url. Also url is used in a bunch of places too, where it is already correct.
This is a semantic nitpick, and probably not worth breaking backwards compatibility over. But worth keeping in mind in case you ever end up doing a big refactor and see an opportunity to clean this up. :)
Feel free to close this bug if it doesn't make sense to pursue at this time.
+1
This is a good idea! However, it will not be fixed in the next version of requests-oauthlib because I want 0.3.4 to make people's lives as easy as possible. =)
Think the only place this would break would be the redirect_uri param and if we want to be careful we could always add redirect_url as a param and raise a deprecation warning when people pass in redirect_uri.
@ib-lundgren Not a bad idea: we should also raise a new issue to remind us to get rid of it eventually. =)
@Lukasa @ib-lundgren As a newcomer, I would like to work upon this issue. Can I ?
a) I agree that a uniform use of one of uri & url is desirable; but
b) I would advocate uri over url
Why b)?
redirect_uriis commonly used. AWS, Google, Auth0 will reportredirect_uri mismatch errors- it may be confusing to set
redirect_urland get aredirect_urierror. - if we assume we should use
redirect_urihere all others should followuriconvention
- it may be confusing to set
- the underlying
oauthlibuses the termuri - a
urlis auri, but auriis not aurl