requests-oauthlib icon indicating copy to clipboard operation
requests-oauthlib copied to clipboard

Version 1.3.1 removed module compliance_fixes.linkedin

Open den4uk opened this issue 3 years ago • 4 comments

The latest release (1.3.1) has a missing module for linkedin compliance fixes.

ImportError: cannot import name 'linkedin_compliance_fix' from 'requests_oauthlib.compliance_fixes'

v1.3.0 still has it: https://github.com/requests/requests-oauthlib/blob/v1.3.0/requests_oauthlib/compliance_fixes/linkedin.py

The removal without a deprecation caused undesired side effects. So far, I managed to catch the change in unit tests, however, expect it to cascade for the rest of the world 🌎 📉

den4uk avatar Jan 30 '22 23:01 den4uk

Agreed the version should have been bumped to 1.4.0 instead. It has been missed somehow. Or a deprecation is also a good idea.

Note that the linkedin seems no longer required as described here https://github.com/requests/requests-oauthlib/pull/397

JonathanHuot avatar Feb 18 '22 21:02 JonathanHuot

Thanks for acknowledgement. Given the breaking changes, this should have really better been a 2.0. It is what it is now. I hope there aren't too many fires out there :)

den4uk avatar Feb 19 '22 22:02 den4uk

@JonathanHuot @den4uk Would it be problematic to release a quick patch? Revert the removal, and add a deprecation warning. Removal can return for 1.4. Or is this too much of a snip snap situation? #485 ???

jtroussard avatar Feb 21 '22 20:02 jtroussard

Since you already have done all the work @jtroussard, I think it is a reasonable ask :) Let's me take care of it.

JonathanHuot avatar Feb 21 '22 20:02 JonathanHuot