requests-oauthlib icon indicating copy to clipboard operation
requests-oauthlib copied to clipboard

Published 20 hours ago • verified publisher icon requests

fetch_token option for params

Open grissman opened this issue 7 years ago • 8 comments

A private API I'm working with requires that the request body be sent as a query string in the url. It's possible that others have encountered the same problem. I allow for this option in this pull request.

grissman avatar Aug 24 '18 01:08 grissman

Coverage Status

Coverage decreased (-0.7%) to 87.318% when pulling b3b9bb918a4a4da5db02413f1e1b33c5183529ec on grissman:master into f8e741dc6a87eecf94e0948b66fe142a79c56fb9 on requests:master.

coveralls avatar Aug 24 '18 01:08 coveralls

Any reason this hasn't been merged?

sargun avatar Nov 23 '18 21:11 sargun

Monthly reminder to check on this!

meyer1994 avatar Dec 22 '18 01:12 meyer1994

There's a lot of duplicated code in this pull request, and it doesn't have any automated tests to cover the new functionality. Can you fix those problems? I'm happy to help, if you're not sure how.

singingwolfboy avatar Dec 27 '18 11:12 singingwolfboy

Since this hasn't been updated in a while, thought I'd chime in. #361

AdamGold avatar Jan 27 '19 11:01 AdamGold

Thank you @AdamGold! I was just getting back to this, but looks like you already got it done.

grissman avatar Feb 25 '19 15:02 grissman

I've tried to pull the actual code changes out into a separate pull request: #369. Could you please review that, and tell me if it solves your problem?

singingwolfboy avatar Feb 26 '19 10:02 singingwolfboy

Since #369 has been merged, can we close this? it appears from the PR's page that this issue was never resolved.

charmingduchess avatar Apr 27 '23 19:04 charmingduchess