sqlite-android icon indicating copy to clipboard operation
sqlite-android copied to clipboard

Re-merge JNI from AOSP

Open mikehardy opened this issue 5 years ago • 0 comments

I was troubleshooting a database problem in AnkiDroid and in my research noticed that the error message given wasn't correct vs AOSP source - the AOSP version was more informative and could help me troubleshoot.

https://github.com/aosp-mirror/platform_frameworks_base/blob/master/core/jni/android_database_CursorWindow.cpp#L58

(that's a mirror but it seems to have perfect fidelity with the google domain version)

That led to a slightly larger investigation and it seems that the AOSP sources have diverged a fair bit

Is there any plan to re-merge JNI from AOSP master?

We still have quite a few crashes in database native code, typically in utf8toJavaCharArray (like so #00 pc 000000000001879c /data/app/com.ichi2.anki-9g7Rz7GpyKqjXYUlwhpVwA==/lib/arm64/libsqlite3x.so (android::utf8ToJavaCharArray(char const*, unsigned short*, int)+160))

There are notes in the newer code commits about UTF8 / UTF16 and this may help us since as a language learning app we deal with high code point characters constantly

mikehardy avatar Oct 03 '18 16:10 mikehardy