requarks
Feat: Add Missing AsciiDoc Blockquotes to Markdown Editor
- Added missing "Tip" and "Caution" blockquotes to Markdown editor that are present in the AsciiDoc editor.
- Modified some Markdown-specific blockquote styling in default style to better match the styling of AsciiDoc pages.
- Fixed inconsistencies in AsciiDoc editor blockquote titles.
I'll look into it again. I couldn't find where the asciidoc styles were coming from. Asciidoc in general, though, doesn't natively support SUCCESS so it would need to be a custom addition.
For consistency, the 'success' blockquote from Markdown should be ported across to AsciiDoc.
I'm still checking this out, but I'm currently stumped finding out where the admonition css class is being set. Once I can figure that out I believe everything will be in parity.
I have finished working to get .md and .adoc editors in parity. One thing to note is that AsciiDoctor.js does not support inline extensions which would allow for the creation of a SUCCESS: option. To get around this a Block extension was created and the editor was modified accordingly.
When you click on the Success Blockquote option now it generates:
[SUCCESS]
There is a new file: asciidoc-extended.js in the client modules that includes the code for creating the new admonition block and it is registered as an extension where asciidoctor is invoked.
@NGPixel I know you're a busy person, but could you review this when you have a moment. I'd like to have this merged in for use in the sites I have wiki.js deployed.
I was just thinking, since this is a feature improvement should I close this PR and recreate it for the Vega branch?