wiki icon indicating copy to clipboard operation
wiki copied to clipboard
verified publisher icon requarks

feat: Add Elasticsearch 8.x support

Open jacobacon opened this issue 2 years ago • 2 comments

Modify ElasticSearch search module to support v8.x.

Changes:

  • Added 8.x to enum in definition.yml
  • Add ElasticSearch 8.x client to dependencies
  • Remove 6.x specific _doc mapping definitions in engine.js
  • Add 8.x specific mappings
  • Modify logic to handle differences between 6.x 7.x / 8.x client responses.

6.x is EOL and no longer supported by ElasticSearch; Some of the logic can be further simplified if support for 6.x is dropped.

Tests: I've tested fairly extensively with 8.x creating, deleting and renaming pages to validate indices are created. I have not done any regression testing against 6.x or 7.x ElasticSearch.

jacobacon avatar Dec 25 '23 23:12 jacobacon

What is missing for this to land in main?

skjoedt avatar Mar 18 '24 08:03 skjoedt

What is missing for this to land in main?

Code wise should be complete now. I've tested with ES 7.x, and 8.x and all features seem to be working as expected. I don't have a 6.x cluster setup, so I wasn't able to test.

@NGPixel, I modified the code to keep the type field for 6.x and 7.x, and merged in upstream changes. Can you review?

jacobacon avatar Mar 23 '24 22:03 jacobacon