wiki icon indicating copy to clipboard operation
wiki copied to clipboard

fix: Helm Chart - Sideloading

Open B3nBeng opened this issue 3 years ago • 5 comments

Context : Wiki container is isolated from the internet, so i enabled sideloading.

Problems :

  1. The init container don't have volumeMounts, so wiki container can't get the locales files previously downloaded.
  2. Wiki container don't use locales files in "sideload" folder because we can't set the option "offline" to true.

Causes the following error "an unexpected error occurred" and menu options + field titles not displaying properly.

Fixs :

  1. Added volumeMounts for the init container, for mount an "emptyDir" with the wiki container, for example.
  • Added var "OFFLINE_ACTIVE" for set offline option.
  • Added offline var in values.yaml

NB : Implies to add "offline: $(OFFLINE_ACTIVE)" into /wiki/config.yml in the docker image.

B3nBeng avatar Jan 16 '23 16:01 B3nBeng

NB : Implies to add "offline: $(OFFLINE_ACTIVE)" into /wiki/config.yml in the docker image.

Then it should be part of the PR in https://github.com/requarks/wiki/blob/main/dev/build/config.yml and tested to make sure it still works if no env var is present.

NGPixel avatar Jan 17 '23 01:01 NGPixel

NB : Implies to add "offline: $(OFFLINE_ACTIVE)" into /wiki/config.yml in the docker image.

Then it should be part of the PR in https://github.com/requarks/wiki/blob/main/dev/build/config.yml and tested to make sure it still works if no env var is present.

It's done. I added a default value "false". It's works correctly.

B3nBeng avatar Jan 17 '23 08:01 B3nBeng

What about non-kubernetes? That config is used for docker images. It needs to work with no value as well.

NGPixel avatar Jan 17 '23 08:01 NGPixel

What about non-kubernetes? That config is used for docker images. It needs to work with no value as well.

Still works in Docker with no values for offline. Tested with this docker-compose : https://docs.requarks.io/install/docker#using-docker-compose

B3nBeng avatar Jan 17 '23 09:01 B3nBeng

@NGPixel Any updates?

bdsoha avatar Feb 23 '23 13:02 bdsoha