wiki icon indicating copy to clipboard operation
wiki copied to clipboard

Sending a letter to the author of the article about a new (deleted/updated) comments.

Open Dzhonn opened this issue 3 years ago • 2 comments

Added the functionality of sending a letter to the author of the article about a new (deleted/updated) comments. The mail settings are taken from the standard module. Created a separate template for notification emails.

3 files server\templates\coment.html server\modules\comments\default\comment.js server\models\comments.js

I might not send something correctly, this is my first time using GIT. Please check those 3 files that I have indicated. I will also leave them as attachments here. mail.zip

Dzhonn avatar Nov 18 '22 03:11 Dzhonn

A few things in your PR that needs to be corrected:

  • Do not add content to README.md
  • Do not add multiple empty lines in the code
  • Do not hardcode strings in the code, especially not in Russian. They can be in English for a PR but ultimately, they should live in Lokalise.
  • Your PR is missing several files (e.g. the template). Don't attach them in a zip file, make them part of your PR.
  • "coment" should be spelled "comment"

NGPixel avatar Nov 18 '22 22:11 NGPixel

This PR seems to have overlapping functions with mine at https://github.com/requarks/wiki/pull/5778.

Gogowitsch avatar Nov 23 '22 10:11 Gogowitsch