Reqnroll icon indicating copy to clipboard operation
Reqnroll copied to clipboard
verified publisher icon reqnroll

Sorted the list of plugins to enable deterministic loading of plugins

Open MWild67 opened this issue 10 months ago • 4 comments

🤔 What's changed?

During plugin discovery the list of found plugins is sorted to enable deterministic loading of plugins

⚡️ What's your motivation?

As described in Ideas #502 the problem is that the plugins are discovered by querying files in directories. This behavior is different depending on the underlying filesystem, means: Window/NFTS: alphanumerical Linux/ext: "inode" order

This leads to the situation that the loading is different when you locally test with Windows and on the pipeline the tests are running on a linux agent.

This is per se a bit inconsistent, but for us it is a problem as we have a plugin which is overwriting the tracing. We enforce by the plugin-name that our plugin is loaded last, which now only works with NTFS.

🏷️ What kind of change is this?

The list of plugins which is given back is sorted alphabetical

♻️ Anything particular you want feedback on?

📋 Checklist:

  • [ ] I've changed the behaviour of the code
    • [ ] I have added/updated tests to cover my changes.
  • [ ] My change requires a change to the documentation.
    • [ ] I have updated the documentation accordingly.
  • [ ] Users should know about my change
    • [X] I have added an entry to the "[vNext]" section of the CHANGELOG, linking to this pull request & included my GitHub handle to the release contributors list.

This text was originally taken from the template of the Cucumber project, then edited by hand. You can modify the template here.

MWild67 avatar Mar 07 '25 07:03 MWild67

Moved the code as proposed to the merger and also added according tests

MWild67 avatar Mar 13 '25 07:03 MWild67

Just seeing that the unit test fails (runs on Linux). I remember from another project that the "ordinal" sorting might depend on the OS, but not sure. We will need to research this.

gasparnagy avatar Mar 13 '25 13:03 gasparnagy

The test for linux itself was wrong ('\' vs '/'), my bad :-).

MWild67 avatar Mar 14 '25 07:03 MWild67

@gasparnagy Where are we here? Can we merge this change back?

MWild67 avatar Apr 07 '25 06:04 MWild67

@MWild67 Thank you for the contribution! According to our guidelines I have invited you to the Reqnroll "contributors team". Congrats! 🎉 If you accept it, you will be able to make pull requests easier in the future.

You are also welcome on our discord server: https://go.reqnroll.net/discord-invite

gasparnagy avatar May 27 '25 06:05 gasparnagy