Reqnroll icon indicating copy to clipboard operation
Reqnroll copied to clipboard

Update Gherkin to 32.0.0

Open obligaron opened this issue 10 months ago • 2 comments

🤔 What's changed?

Update Gherkin to 32.0.0 and fixed related breaking changes.

⚡️ What's your motivation?

Updating to the latest version and Gerhkin 32.0.0 contains performance improvements. The new version improves the feature file generation time of the BigReqnrollProject from ~1262ms to ~1033ms (22% improvement) on my machine.

🏷️ What kind of change is this?

  • :bank: Refactoring/debt/DX (improvement to code design, tooling, etc. without changing behaviour)
  • :boom: Breaking change (incompatible changes to the API)

♻️ Anything particular you want feedback on?

Gherkin 32.0.0 contains some (minor) breaking changes that are easy to fix, but they are still breaking changes. These breaking changes can also affect Reqnroll plugins, see for example failing SpecSyncPlugin tests. How do we handle this?

📋 Checklist:

  • [x] Users should know about my change
    • [ ] I have added an entry to the "[vNext]" section of the CHANGELOG, linking to this pull request & included my GitHub handle to the release contributors list.

This text was originally taken from the template of the Cucumber project, then edited by hand. You can modify the template here.

obligaron avatar Feb 22 '25 19:02 obligaron

The failing build is actually just an indicator that this change is breaking for an "average" plugin that uses the AST.

Please ignore that test like we did in https://github.com/reqnroll/Reqnroll/pull/233/commits/da0214222a6df161549d13c8b567332683baccab

We will need to delay merging this then, before we start v3.0.

gasparnagy avatar Mar 06 '25 10:03 gasparnagy

I updated/ignored the tests. I keep the PR as draft until we start with developing v3.0.

obligaron avatar Mar 19 '25 19:03 obligaron