nightwalker
nightwalker copied to clipboard
repslet
Broken on v4.5
Love the theme, but it has stopped working on the new v4.5 of qBit, any chance of a fix?
Seems this is by design https://github.com/qbittorrent/qBittorrent/pull/17616#issue-1352385080 . This issue https://github.com/qbittorrent/qBittorrent/issues/18109#issue-1469149955 recommends using some regex to fix up strings, but as mentioned in that, it doesn't fix all.
Was able to fix this by downloading the current web ui, running the regex's to remove the language translation string placeholders and re-applying the custom stylesheets from the theme. All working after that.
Was able to fix this by downloading the current web ui, running the regex's to remove the language translation string placeholders and re-applying the custom stylesheets from the theme. All working after that.
Could you fork the repo and make a PR with the fix?
Here is the fork, https://github.com/CallMeBruce/nightwalker, not sure about a PR, there is probably some content that doesn't need to be there and I just did a rush job.
As noted upstream in my qbittorrent issue #18602, problem is persistent. It was originally observed in another issue report, qbittorrent issue #18109. However, after some snark from qBT developers, the problem is unresolved and without steps to diagnosis/resolve.
Last night, I make a diff of @CallMeBruce repo and this repo.
I suspect @CallMeBruce had CSS and JS code formatters in use. This made generating a diff a touch more difficult as spacing and tag ordering conflated any repo diff.
Also when generating the diff, I made a conscious choice to NOT touch the JS code in this repo. I suspect that @CallMeBruce employs a javascript linter. This highlighted a few instances where there were missing semicolons in this repo. I'll make a separate pull for others to examine.
Also of note in generating the diff was that @CallMeBruce repo updated dependent JS libraries. I am not conversant in JS, these kinds of changes would require others to consider.
I found a couple of image file issues (file in private/images but not public/images and vice versa - eg: qbittorrent32.png) in this repo. I'm still trying to track down source of a couple of other instances where I encountered missing images before making a PR.
Overall, just stripping out QBT_TR references in the HTML pages did not work for me. I suspect that there are other changes in the JS that need to be performed.
Backing away from commitment to PR semicolon changes. Linting of folder produces overwhelming results. Not being versed in nodejs is beyond current capabilities.
Sad really. This is a very useful theme.
FWIW, duplicate icon folder in [project_root]/private/icons
@CallMeBruce Any chance of a redo for 4.6.0, since you fork seems to have stopped working?
@CallMeBruce Thank you man, it took me too much time to find a working dark theme. But I think your fork missing the flags folder image, so there is no country image when access to Peers tab in each torrent.
It took me a while to figure out that just copy the flags folder and it fix nicely.
Thanks for updating it Bruce, I had issues with tpark. Now nightwalker works perfectly.
And @lilws , thanks for pointing it out. Therefore flags folder should be placed inside /images, and not inside /icons, in order for the flags to be properly displayed in peer list.
No worries @lilws and @C8opmBM , I also just updated the repo with this flag change
I personally use this until the problem is fixed: https://github.com/Carve/qbittorrent-webui-cjratliff.com
What problem do you have? It works perfectly https://github.com/CallMeBruce/nightwalker And as you can see, Bruce updated the flags folders.