app icon indicating copy to clipboard operation
app copied to clipboard

Team remove should not fail if team could not be deleted

Open jurijzahn8019 opened this issue 2 years ago • 0 comments

Problem Description

Update settings fails if team can not be removed from repo due to organizational restrictions.

here: https://github.com/repository-settings/app/blob/97c12a3ff2d9ecb967abf07a19d78bdd66e10dfe/lib/plugins/teams.js#L33

What is actually happening

If a team has been granted permittions to the repo on an organizational level It can not be removed. This causes team plugin to fail which stops settings update.

What is the expected behavior

If a team permission can not be deleted due to permission error (or an error in general) it should be skipped as unresolvable.

Error output, if available


Context

Are you using the hosted instance of repository-settings/app or running your own?

no

If running your own instance, are you using it with github.com or GitHub Enterprise?

Version of repository-settings/app

Version of GitHub Enterprise

jurijzahn8019 avatar Jan 31 '23 11:01 jurijzahn8019