app icon indicating copy to clipboard operation
app copied to clipboard

Published 20 hours ago • verified publisher icon repository-settings

Enforce signed commits

Open SamuelCabralCruz opened this issue 3 years ago • 3 comments

Prerequisites:

image

New Feature

provide setting to enforce signed commits

SamuelCabralCruz avatar Mar 06 '21 23:03 SamuelCabralCruz

please provide the remaining details asked for in the issue template

travi avatar Mar 07 '21 03:03 travi

@SamuelCabralCruz required_signatures should work. See: https://github.com/probot/settings/issues/220#issuecomment-613741695

I did use it on a recent greenfield project and was working fine, BUT I do have occurrences of branch protection not being applied at all, with and without required_signatures being specified. I was not able to get down to the root of the issue so far. Would be interesting to be able to see error logs, maybe we could deploy our own instance of the app to get to the root of this.

johnmartel avatar Mar 25 '21 14:03 johnmartel

@johnmartel I did check on your repo I forgot about this issue. It did work as expected. For the branch protection not being applied, I experienced the same issue but I observed that it seems to be due to partial branch protection configuration. Would be nice to do some further investigations.

SamuelCabralCruz avatar Mar 25 '21 15:03 SamuelCabralCruz