app icon indicating copy to clipboard operation
app copied to clipboard

Sync settings after App installation

Open mvegter opened this issue 6 years ago • 7 comments

Fixes #1

Implementation has overlap with #179

mvegter avatar Nov 16 '19 10:11 mvegter

am i correct in understanding that this would directly update the file in the default branch? if so, it seems dangerous to do this without submitting the changes as a PR to give the repository maintainer a change to review and accept the changes. if a project already has the settings file, it's likely that there is a reason for it to include the contents that it does, even if it should be supplemented with additional details.

travi avatar Nov 21 '19 05:11 travi

What do you mean with directly updating the settings file?

The flow this results in:

  • Probot settings is installed by user (all or selected repos)
  • Probot will loop the previous repos and if it finds a settings file it will sync it
  • If the user installs additional repos it will repeat this loop for the new repos.

mvegter avatar Nov 24 '19 09:11 mvegter

sorry, i definitely misunderstood the goal. i was thinking about the opposite situation where a repo without an existing file would have one created by pulling the existing settings for that repo through the api and written to the config file. i think there was an issue for that at one point, so i think i made the wrong assumption before reading deeply enough.

with a better understanding now, i do see high value to this. i have been really busy lately, but will try to look through your PR soon and give feedback soon.

travi avatar Dec 04 '19 05:12 travi

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

stale[bot] avatar Mar 07 '20 18:03 stale[bot]

sorry that i still havent gotten to this, but it is still on my radar

travi avatar Mar 07 '20 20:03 travi

Maybe ping @travi ? 😊

rogerluan avatar Oct 09 '22 23:10 rogerluan