RepoSense icon indicating copy to clipboard operation
RepoSense copied to clipboard

Published 20 hours ago • verified publisher icon reposense

Minimal coverage of CSS files

Open jamessspanggg opened this issue 5 years ago • 4 comments

Problem: When using Coverage tab in Chrome dev tools to analyse the coverage of our CSS and JS files, it is shown that we are utilising vue-loading-spinner.css and mui.min.css in a small percentage.

Screen Shot 2019-06-26 at 11 58 34 PM

Running audits in the Chrome dev tools also shows that there will be potential savings in loading time if we remove both css files. Screen Shot 2019-06-26 at 11 59 22 PM

Suggestion: Since we are using only a small part of these two files, let's remove the importing of these files and create our own css classes that achieves the style required.

jamessspanggg avatar Jun 27 '19 03:06 jamessspanggg

@jamessspanggg the usage of mui.min.css has increased. Do let me know if you still want me to create our own css class for this style.

Screen Shot 2019-09-24 at 2 49 08 AM

Tejas2805 avatar Sep 23 '19 18:09 Tejas2805

@Tejas2805 it may be better to focus on other issues as this issue may not be as critical.

jamessspanggg avatar Sep 23 '19 23:09 jamessspanggg

@jamessspanggg I have already worked on removing the vue-loading-spinner.css. So maybe I will just do a pull request for that for the time being?

Tejas2805 avatar Sep 24 '19 06:09 Tejas2805