RepoSense icon indicating copy to clipboard operation
RepoSense copied to clipboard

Published 20 hours ago • verified publisher icon reposense

Show commit details in code view

Open damithc opened this issue 5 years ago • 5 comments

Current: when the user clicks on a ramp, we open the GitHub page showing the commit

Suggested: show the commit in the code view instead

Possibly related: #63

damithc avatar May 17 '19 06:05 damithc

Possibly related: #148

fzdy1914 avatar Dec 09 '19 08:12 fzdy1914

@myteo did some exploration on this front. It seems the cost is too high to achieve this, in terms of processing time as well as storage space.

damithc avatar Mar 03 '20 14:03 damithc

I found the github API that will return the commit diff, sth like the image below, and there are open source diff parser but havnt tested. If we only make the api query when clicking the ramp I guess the cost might be ok? The problem is we need to import the parser and deal with cors issue. image

0blivious avatar Mar 06 '20 07:03 0blivious

I found the github API that will return the commit diff, sth like the image below, and there are open source diff parser but havnt tested. If we only make the api query when clicking the ramp I guess the cost might be ok? The problem is we need to import the parser and deal with cors issue.

Unauthenticated users have severe API quota limitations though.

damithc avatar Mar 06 '20 07:03 damithc

I will leave two related issues here for reference but close them. Issues are: #63, #148.

fzdy1914 avatar Jan 19 '21 11:01 fzdy1914