reposense
Refactor code smells
Proposed commit message
This project contains implement and design smells.
Introduce an explaining variable to address magic number.
Decompose conditional to address complex conditional.
Extract a class from CommitAnalyzer to address deficient encapsulation.
Hi @JHyeon0915, thanks for your contribution!
Could you also review the codebase for other instances of similar code quality issues, such as magic numbers/strings, complex conditionals, and opportunities for better abstraction or encapsulation? Identifying these areas will help us consolidate code-quality improvements of the entire codebase within this PR.
Looking forward to your insights!
@joeng03 Hello! Thank you for your feedback. Yes, there are some more smells. But I am currently on the final exam period and I will be able to work in a month. So, I will try to contribute more a bit later if that's okay. Let me know if anything comes up.
Hi, We are going to mark this PR as stale because it has been inactive for the past 30 days. If no further activity occurs within the following 7 days, it will be automatically closed so that others can take up the issue. If you are still working on this PR, please make a follow-up commit within 7 days and leave a comment to remove the stale label. Do let us know if you are stuck so that we can help you!'
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
Hi @joeng03 ! I hope you have been doing well! I'd like to share the progress with you.
I have checked Implementation and Design smells for the past couple of days and was able to fix some of them. While implementation smells are mostly trivial(Long Statement, Long Identifier, etc), there are some design smells left that could be fixed (Cyclically-dependent Modularization, Deficient Encapsulation, etc). The approximate number of design smells is about 15-20, which I want to say is moderate).
As this PR has been marked as stale since five days ago, you can either unmark this PR if you'd like me to work more or merge / close after your review. Thank you.
Hi @joeng03 , how are you doing? Since the summer semester has started, I'd like to wrap up this contribution. Please review this PR as the final code and let me know if I need to fix anything! Thank you.
Hi, We are going to mark this PR as stale because it has been inactive for the past 30 days. If no further activity occurs within the following 7 days, it will be automatically closed so that others can take up the issue. If you are still working on this PR, please make a follow-up commit within 7 days and leave a comment to remove the stale label. Do let us know if you are stuck so that we can help you!'
This PR was closed because it has been marked as stale for 7 days with no activity. Feel free to reopen this PR if you would like to continue working on it.