RepoSense icon indicating copy to clipboard operation
RepoSense copied to clipboard

Ensure unique display name

Open yong24s opened this issue 6 years ago • 2 comments

From @yamidark comment in #210

Hmm, this may give rise to the same problem mentioned in #206, whereby we give 2 different locations but the folder name is same, and use the same branch, end up overriding each other's report. Perhaps we can temporarily set the repoName to be the absolute path, just replace the file separators with _?

In #210, location accepts both github url and disk location.

Display nameis used for the name of the cloned file, which are generated by normalizing a path or a git url.

For example, https://github.com/organization/main.git -> organization_main_branch and C:/path/to/repository -> repository_branch.

Thus, it is possible for a repository with a similar name and branch to interfere with RepoSense's analysis.

yong24s avatar Jul 23 '18 07:07 yong24s

We should ensure that display names are unique instead because it will still interfere the result if 2 teams happen to have the same display name.

eugenepeh avatar Oct 02 '18 01:10 eugenepeh

I believe we can discuss whether to close this issue or discuss its importance as it is somewhat similar to https://github.com/reposense/RepoSense/issues/1637. Local repositories now use the full path specified as the output directory's name and should be far less likely to clash now.

E.g. Using the local repo ./path/to/file/reponame gives the output directory ._path_to_file_reponame

chan-j-d avatar Jan 27 '23 18:01 chan-j-d