RepoSense icon indicating copy to clipboard operation
RepoSense copied to clipboard

Add cypress test for show tag when grouping by author [#2195]

Open jonasongg opened this issue 9 months ago • 1 comments

Fixes #2195

Proposed commit message

Add cypress test for show tag when grouping by author

Currently, there are no Cypress tests to test the behaviour of the show
tag feature when the report is grouped by author.

Let's add a test for this to ensure the feature is working properly.

Other information

jonasongg avatar Apr 30 '24 10:04 jonasongg

@ckcherry23 the bug with group by none actually happened because of a change I made in this PR to fix group by author. i fixed the bug in this PR already, so all group by options should be working correctly. (also added some tests for this!) do i need to create a new issue + PR to address the original bug?

jonasongg avatar May 01 '24 19:05 jonasongg

@ckcherry23 the bug with group by none actually happened because of a change I made in this PR to fix group by author. i fixed the bug in this PR already, so all group by options should be working correctly. (also added some tests for this!) do i need to create a new issue + PR to address the original bug?

If everything works as expected now, we do not need a new issue + PR. The current PR seems to have fixed all the issues, is there anything missing?

ckcherry23 avatar May 11 '24 07:05 ckcherry23

@ckcherry23 done, thanks!

jonasongg avatar May 11 '24 18:05 jonasongg

The following links are for previewing this pull request:

  • Dashboard Preview: https://dashboard-2197-pr-reposense-reposense.surge.sh
  • Docs Preview: https://docs-2197-pr-reposense-reposense.surge.sh

github-actions[bot] avatar May 12 '24 08:05 github-actions[bot]