RepoSense icon indicating copy to clipboard operation
RepoSense copied to clipboard

[#1872] Update Node version to 18

Open sopa301 opened this issue 1 year ago • 4 comments

Fixes #1872

Proposed commit message

Node.js 16 has reached its end-of-life on 11 September 2023.

Let us update Node.js to use Node 18 in the GitHub workflows.

Other information

The update involved removing the depreciated node-sass.

sopa301 avatar Jan 16 '24 08:01 sopa301

Closed because I don't have the required competencies (as of now) to properly fix the issue. Here are some things I learned in the process.

  • Updating Node to 18 requires node-sass to be updated to at least 8.0
  • However, node-sass has been depreciated in favor of dart-sass (sass), which is already used in the project.
  • Additionally, node-sass on windows has a few more requirements that make it harder to set up.
  • Therefore, it would be easier to remove node-sass and use sass exclusively.
  • Attempting to do so resulted in a bug similar to #1784

sopa301 avatar Jan 18 '24 13:01 sopa301

The following links are for previewing this pull request:

  • Dashboard Preview: https://dashboard-2081-pr-reposense-reposense.surge.sh
  • Docs Preview: https://docs-2081-pr-reposense-reposense.surge.sh

github-actions[bot] avatar Jan 18 '24 13:01 github-actions[bot]

Thanks @sopa301 for your detailed investigation regarding the issue and reporting it here! We can figure out a fix for this in a future PR.

ckcherry23 avatar Jan 18 '24 16:01 ckcherry23

It's interesting to note #2102 somehow fixed the bug mentioned above.

sopa301 avatar Feb 19 '24 07:02 sopa301

@vvidday Updated!

sopa301 avatar Mar 16 '24 10:03 sopa301

@vvidday Updated!

thanks! :)

vvidday avatar Mar 16 '24 10:03 vvidday

The following links are for previewing this pull request:

  • Dashboard Preview: https://dashboard-2081-pr-reposense-reposense.surge.sh
  • Docs Preview: https://docs-2081-pr-reposense-reposense.surge.sh

github-actions[bot] avatar Mar 19 '24 07:03 github-actions[bot]