RepoSense icon indicating copy to clipboard operation
RepoSense copied to clipboard

URL Changes upon refresh

Open SkyBlaise99 opened this issue 1 year ago • 2 comments

Tell us about your environment

  • RepoSense Version: Current latest 5cd529f
  • OS and Version: Windows 11
  • Web Browser and Version (if applicable): Chrome Version 118.0.5993.71 (Official Build) (64-bit)

Please include the steps to reproduce the bug.

  1. Generate a report and view it java -jar RepoSense.jar -repo https://github.com/reposense/RepoSense.git -v
  2. Click to view author's (Eugene's) contribution
  3. Input README.md into Filter by glob
  4. The current URL is http://localhost:9000/?search=&sort=groupTitle%20dsc&sortWithin=title&since=2018-05-03&timeframe=commit&mergegroup=&groupSelect=groupByRepos&breakdown=false&tabOpen=true&tabType=authorship&zFR=false&tabAuthor=eugenepeh&tabRepo=reposense%2FRepoSense%5Bmaster%5D&authorshipIsMergeGroup=false&authorshipFilesGlob=README.md
  5. Refresh the webpage, the URL changes to http://localhost:9000/?search=&sort=groupTitle%20dsc&sortWithin=title&since=2018-05-03&timeframe=commit&mergegroup=&groupSelect=groupByRepos&breakdown=false&tabOpen=true&tabType=authorship&zFR=false&tabAuthor=eugenepeh&tabRepo=reposense%2FRepoSense%5Bmaster%5D&authorshipIsMergeGroup=false&authorshipFilesGlob=README.md%23%2F (extra %23%2F)
  6. The search bar is now README.md#/

What was expected to happen?

The search bar should remain at README.md

What actually happened? Please include a screenshot of the output.

Before: image

After referesh: image

If possible, include the URL to your RepoSense report or log files (if any).

SkyBlaise99 avatar Oct 11 '23 07:10 SkyBlaise99

It seems to be related to #1987 in some ways, from what I observe, %23%2F is first attached to the url, causing the search input to be different, hence returning different or no results. At this point of time, the authorshipFilesGlob param seem to disappear from the url subsequently, hence upon the 2nd refresh, the Glob filter automatically resets.

SkyBlaise99 avatar Oct 11 '23 07:10 SkyBlaise99

@reposense/active-reviewers-1 This might be fixed with #2086?

jonasongg avatar Feb 13 '24 16:02 jonasongg

Fixed by #2086

ckcherry23 avatar Mar 09 '24 14:03 ckcherry23