RepoSense icon indicating copy to clipboard operation
RepoSense copied to clipboard

[#1665] rename frontend component

Open Jay-luozhijie opened this issue 2 years ago • 5 comments

Add changes according to [#1665]

Proposed commit message

The components are all named with a prefix -v; however, most reserved syntax used by Vue uses the -v .

Let's change the -v prefix to prefix -c, so that it will be less likely to cause confusion

Other information

I tried to just remove the prefix previously, but the summary is a reserved word in html, thus the v-summary can't be renamed. So I add -c as a prefix.

Jay-luozhijie avatar Sep 06 '22 13:09 Jay-luozhijie

Hi @Zhou-Jiahao-1998 , I have solved the conflict and now created a new pull request

Jay-luozhijie avatar Sep 06 '22 14:09 Jay-luozhijie

@LuoZhijie-tom Hi there, please update the cypress tests as well to reflect the changes. You can find the files under frontend/crypress folder.

zhoukerrr avatar Sep 08 '22 04:09 zhoukerrr

@LuoZhijie-tom Hi there, please update the cypress tests as well to reflect the changes. You can find the files under frontend/crypress folder.

Hi @Zhou-Jiahao-1998 , I have modified the code and it passed the cypress test now, could you have a look?

Jay-luozhijie avatar Sep 11 '22 11:09 Jay-luozhijie

Guys, shall we push this PR forward?

damithc avatar Sep 24 '22 12:09 damithc

@dcshzj I have updated the diagrams, could you have a look?

Jay-luozhijie avatar Oct 02 '22 08:10 Jay-luozhijie

Guys, shall we merge this?

damithc avatar Oct 09 '22 06:10 damithc

The following links are for previewing this pull request:

  • Dashboard Preview: https://dashboard-1836-pr-reposense-reposense.surge.sh
  • Docs Preview: https://docs-1836-pr-reposense-reposense.surge.sh

github-actions[bot] avatar Oct 09 '22 09:10 github-actions[bot]