RepoSense icon indicating copy to clipboard operation
RepoSense copied to clipboard

[#1689] Disable links when they are broken

Open Jay-luozhijie opened this issue 2 years ago • 2 comments

Add changes according to [#1689]

Proposed commit message

There are some links in the report to the report repos such as view group repo; however, when the link is missing or not supported by repoSense(is not Github, GitLab or Bitbucket), it redirects to non-existent link.

Let's disable the link when it is broken and change the message when the users hover over the link to This remote link is unsupported so that the users will know that the link is broken.

Other information

This feature is added to commit ramp link, link to author profile, link to group repo tree, link to blame view and link to history view according to [#1689]

This is a sample: sample

Jay-luozhijie avatar Aug 21 '22 16:08 Jay-luozhijie

In addition to the review comments, can you also provide a test report that showcases the functionality that you have added? The repositories that we are currently using are from GitHub, GitLab and Bitbucket. Feel free to include any small repository that are not hosted by the 3 hosting providers and provide us with a link to that report. Thanks!

Hi @dcshzj I have added a new remote repository from sourceforge and modified the code according to your advice, could you have a look is this what you mean?

Jay-luozhijie avatar Sep 11 '22 11:09 Jay-luozhijie

@dcshzj @gerhean let's push this PR forward.

damithc avatar Sep 24 '22 12:09 damithc

Are you able to resolve the file conflicts?

dcshzj avatar Oct 11 '22 01:10 dcshzj

The following links are for previewing this pull request:

  • Dashboard Preview: https://dashboard-1830-pr-reposense-reposense.surge.sh
  • Docs Preview: https://docs-1830-pr-reposense-reposense.surge.sh

github-actions[bot] avatar Oct 11 '22 17:10 github-actions[bot]

Oh sorry, I just resolved the file conflicts

Jay-luozhijie avatar Oct 11 '22 17:10 Jay-luozhijie

The following links are for previewing this pull request:

  • Dashboard Preview: https://dashboard-1830-pr-reposense-reposense.surge.sh
  • Docs Preview: https://docs-1830-pr-reposense-reposense.surge.sh

github-actions[bot] avatar Oct 16 '22 07:10 github-actions[bot]