RepoSense
RepoSense copied to clipboard
Unclear percentage meaning under summary-charts when groups are sorted by contribution
What feature(s) would you like to see in RepoSense?

If possible, describe the solution
This was done as part of my phase 2, in which I have attached a help icon next to the percentage, and if the viewers click on it, they can see a modal describing what the number means.
However, since modal is quite a departure from the current design, for this issue, I would like to address it in a way that when a viewer hovers on the help icon, a small pop up message (like all others) shows up and displays the description.
However, since modal is quite a departure from the current design, for this issue, I would like to address it in a way that when a viewer hovers on the help icon, a small pop up message (like all others) shows up and displays the description.
Yes, a popup containing a short description might work. But watch out for the increase in page size too. I'm a bit worried that adding a repetitive content can bloat the page size too much.
@damithc
I see your concern.
Is there a way to verify whether the page size has increased?
Is looking at the file size for index.html
under reposense-report
directory a correct way to verify it?
Is there a way to verify whether the page size has increased? Is looking at the file size for
index.html
underreposense-report
directory a correct way to verify it?
Probably, but best verified by a senior dev.
Is there a way to verify whether the page size has increased? Is looking at the file size for
index.html
underreposense-report
directory a correct way to verify it?
The page size would be affected by the size of js/app.js
in the reposense-report
directory. I think this change should be not too significant, and only the text needs to be adjusted for each instance of the modal.
In the future, it is likely that we need to do proper profiling of the frontend performance to see where our bottlenecks are.
@dcshzj
I see. Then could you assign me on this one? I will see how the size varies after the change.