RepoSense icon indicating copy to clipboard operation
RepoSense copied to clipboard

Create ramp chart(s) for "virtual authors"

Open anubh-v opened this issue 5 years ago • 4 comments

After #823 is fixed, users will be able to disown code by using author tags like @@author some-randomuser, where some-randomuser is not the git authorname of any author in the AuthorConfiguration.

As discussed in issue 1022, we can add ramp chart(s) for authors like some-randomuser, so that users can easily access all code that has been disowned.

This will also benefit users who meant to claim certain code blocks but made typos in the author tags.

Note: this issue should probably be tackled after #823 is fixed.

anubh-v avatar Feb 15 '20 12:02 anubh-v

Prof @damithc, @eugenepeh , may I confirm if we can create a single ramp chart that captures the work attributed to all virtual authors (as opposed to 1 ramp chart per each virtual author) ?

This decision will influence the implementation for the bugfix in #1067 Prof @damithc, I recall you mentioned that we should adopt the path that takes lesser development effort.

My view is that creating a single ramp chart for all virtual authors will be simpler. We can create one additional dummy author for each repo (the UNKNOWN_AUTHOR), and credit all disowned code to this author.

anubh-v avatar Mar 01 '20 04:03 anubh-v

Prof @damithc, @eugenepeh , may I confirm if we can create a single ramp chart that captures the work attributed to all virtual authors (as opposed to 1 ramp chart per each virtual author) ?

Sure. Go ahead.

damithc avatar Mar 01 '20 06:03 damithc

Prof @damithc, @eugenepeh , may I confirm if we can create a single ramp chart that captures the work attributed to all virtual authors (as opposed to 1 ramp chart per each virtual author) ?

I would prefer not because that is sort of making //@@author a half baked feature. If it is possible to attribute them as UNKNOWN_AUTHOR then it shouldn't cost much extra code to separate them into individual identities given that the value is already provided together with the tag.

If it would a lot more to implement that change, then its an indication that there's a problem in the underlying structure that should also be fixed.

eugenepeh avatar Mar 01 '20 14:03 eugenepeh

@eugenepeh, ok, I will implement the bugfix in #1067, with the view that our goal is to have separate ramp charts for virtual authors. I'll discuss with the team in the event that major architecture changes are needed

anubh-v avatar Mar 04 '20 08:03 anubh-v