service-ui icon indicating copy to clipboard operation
service-ui copied to clipboard

Increase number of chars in description of a launch to 4096

Open msisam opened this issue 2 years ago • 11 comments

We use the launch description to allow our users to have that information presented within the launch description such as links, artifacts, OKR Results. But the limit of 1024 chars trims most of the links and data from there.

Example: Screen Shot 2022-05-26 at 20 03 10

msisam avatar May 23 '22 16:05 msisam

Hello @msisam ! Thanks for your PR! We need to discuss your proposal with the team and BA to see all options regarding this restriction. Stay in touch! @evjlobanova and @VolhaKarenko what do you think about this improvement?

AmsterGet avatar May 23 '22 16:05 AmsterGet

@AmsterGet Thanks! I also checked in the Schema it looks like it's not limited there https://github.com/reportportal/migrations/blob/324e18968b32f3b16a146b6f80a1e6fb609ac054/migrations/1_initialize_schema.up.sql#L387

This will be a really big help for us as we will be able to complete the visibility for all related information of a launch Please Let me know what you think!

msisam avatar May 23 '22 16:05 msisam

@VeranikaRymzha @Kozovskaya please take a look

VolhaKarenko avatar May 24 '22 09:05 VolhaKarenko

Hey, Would love to get any response regarding this please I guess it's not a big change so maybe we can push this forward?

Thanks!

msisam avatar May 26 '22 16:05 msisam

Hello @msisam, I'm sorry for the late reply. We'll discuss this issue with the team next week and come back to you with the updates.

VeranikaRymzha avatar May 27 '22 18:05 VeranikaRymzha

Thanks @VeranikaRymzha

msisam avatar May 27 '22 20:05 msisam

Hello @msisam, Just to keep you updated. The task is in progress. At the moment the team investigates the question so as to find the optimal number of chars from backend, frontend and performance perspective. I'll keep you posted.

VeranikaRymzha avatar Jun 06 '22 15:06 VeranikaRymzha

Hey @VeranikaRymzha Any chance you can update the current status of this?

thanks!

msisam avatar Jun 16 '22 07:06 msisam

Hey @msisam, Thank you for your patience.

Following the results of the investigation stage (performance tests results + design team recommendations) we won't be able to increase the limit for the number of chars in launch description to 4096. I'm sorry.

However, we plan to increase it up to 2048 which won't affect negatively performance and user performance, and hopefully will benefit ReportPortal users. The development team is working on this task at the moment.

VeranikaRymzha avatar Jun 17 '22 14:06 VeranikaRymzha

Hi @VeranikaRymzha any update on this one? I'm trying to find the change in master or other branches but still can't see it.

Thanks

msisam avatar Aug 25 '22 09:08 msisam

Hi @msisam, Sorry for my late reply.

The adjustments have been implemented. But they will be released in Version 5.7.3 (we plan to have it in September-October).

Important moment: we were able to increase the limit for the number of chars in launch description to 2048 only due to Performance and UX limitations we have. Please, let me know if there are any other questions.

VeranikaRymzha avatar Aug 26 '22 14:08 VeranikaRymzha