reportportal icon indicating copy to clipboard operation
reportportal copied to clipboard

[v5] Filter by Attribute Value unresponsive when there is a large amount of unique attribute values

Open naddison opened this issue 3 years ago • 12 comments

Describe the bug The filter by attribute value option is taking too long to load, and halts.

To Reproduce

  1. Try to filter launches by Attribute Value.

Expected behavior The attribute value box should find matching values as the user types.

Screenshots rp_attribute_value_filter_fail

Desktop (please complete the following information):

  • OS: Windows 10
  • Browser: Chrome
  • Version: 90.0.4430.212

Additional context When digging into the network log I saw that the filter was waiting for the response to this HTTP GET. api/v1/<project-name>/launch/attribute/values?filter.cnt.attributeValue=juno.

Eventually this does return, but its response is huge 76k+ entries. It looks like the API is returning every possible value to attributeValue in the project and leaving it to the UI to fulfill the autocomplete feature and sort through the large amount of values, which is choking the UI in the browser.

It would make sense to me that the server does more processing on the possible results and returns smaller result size, or at least support pagination on these results as the UI performs the autocomplete feature.

naddison avatar Jun 03 '21 17:06 naddison

If you choose also the attribute key refine, it reduces the number of possible attribute values

evjlobanova avatar Jun 03 '21 17:06 evjlobanova

Ahh fair enough. I still think a valid performance issue, or perhaps you shouldn't allow filtering by Attribute Value, without first defining a key.

naddison avatar Jun 03 '21 18:06 naddison

I agree with you, that it is not correct behavior. We will think about it. Actually, we are planning to rework this filter and add a possibility to filter by pair key: value. And have only 1 field for filter instead of Filter by key, and filter value

evjlobanova avatar Jun 03 '21 18:06 evjlobanova

Looks like, this issue not fixed yet and still reproduced in Report Portal 5.7.2?

lastas avatar Nov 04 '22 09:11 lastas

Hi everyone. We use Report Portal 5.7.3 and this issue really make our work annoying and extremely slow( I and my colleagues will be really grateful and much happier if this issue will be fixed in the nearest future.

Is it possible to do soon?)

Gruuuubik avatar Mar 22 '23 15:03 Gruuuubik

Hello @Gruuuubik, @lastas @naddison! The mentioned component was updated in version 5.6 of ReportPortal. Now instead of separate fields for attribute key and attribute value we have only one field: image

Is your case is till reproducible in the new component?

Kozovskaya avatar Nov 14 '23 10:11 Kozovskaya

Hi @Kozovskaya. Thanks for answer.

As I mentioned above I used 5.7.3 and now we use 5.7.4, but problem is still the same:

Example of search by key and then by value:

image

Possible solutions:

  1. Allow to click OK button without waiting for the end of searching - it will help to add attribute quicker if I already have exact and full attribute for searching.
  2. Add parameter to RP to turn on/off typeahead for attribute dropdown - it will help to turn off it for some customers but some other users may leave this searching as is if it is suitable for them.

Gruuuubik avatar Nov 14 '23 17:11 Gruuuubik

@VolhaKarenko could you please check the issue? Try to reproduce

Kozovskaya avatar Nov 15 '23 12:11 Kozovskaya

Hello @Gruuuubik,

Thank you for highlighting the issue. I've registered a task in our Team's backlog to discuss how we can improve the component behavior to resolve performance degradation for the cases described.

alena-babrova avatar Nov 28 '23 07:11 alena-babrova

Hello @alena-babrova.

Thanks for help. Do you have any information when this discussion can be done and when some fix can be provided?

Gruuuubik avatar Nov 28 '23 13:11 Gruuuubik

Dear @Gruuuubik,

The issue is still in the approval stage to be taken into work. Once it is approved to any upcoming release, I will update the status here.

alena-babrova avatar Nov 29 '23 07:11 alena-babrova

Thank you @alena-babrova for help. Will wait for your response.

Gruuuubik avatar Nov 29 '23 07:11 Gruuuubik