kubernetes icon indicating copy to clipboard operation
kubernetes copied to clipboard

add istio ingress options

Open Jmainguy opened this issue 1 year ago • 2 comments

Taking @nabbott2008 virtualservice from https://github.com/reportportal/kubernetes/issues/185, and adding it as an option to the chart.

Fix some typos in the README.md move around some information to make it clear ingress isn't the only option.

Would love more feedback on the README.md changes and where to place the values, I figured under ingress would make sense, could argue for moving it to its own block if you wanted to.

Jmainguy avatar Oct 11 '22 20:10 Jmainguy

We are using the virtual service and gateway at $JOB, works well for us.

Jmainguy avatar Oct 11 '22 20:10 Jmainguy

https://github.com/reportportal/kubernetes/issues/274 is related in the same vein, a third ingress option. Depending on what we do in this PR, will make fixing that issue easier.

Jmainguy avatar Oct 11 '22 20:10 Jmainguy

@Jmainguy Please check out my comments.

HardNorth avatar Oct 27 '22 13:10 HardNorth

Thank you for feedback, will work on fixing up

Jmainguy avatar Nov 02 '22 14:11 Jmainguy

Hei question,

What is the reason this PR got closed without mergin?

GianniGiglio avatar Jun 25 '24 08:06 GianniGiglio

@GianniGiglio hi. You didn't answer on the comments a long time.

raikbitters avatar Jun 25 '24 10:06 raikbitters

@raikbitters I wasn't involved in this ticket just bumped on it by accident and I was wondering if you guy's where planning to support istio ingress since I have a simular use case. :)

You have me confussed with someone else :)

GianniGiglio avatar Jun 25 '24 12:06 GianniGiglio

@GianniGiglio sorry for the misunderstanding. We don't consider supporting Istio right now. However, you can suggest your solution via PR.

raikbitters avatar Jul 05 '24 12:07 raikbitters