kubernetes
kubernetes copied to clipboard
add istio ingress options
Taking @nabbott2008 virtualservice from https://github.com/reportportal/kubernetes/issues/185, and adding it as an option to the chart.
Fix some typos in the README.md move around some information to make it clear ingress isn't the only option.
Would love more feedback on the README.md changes and where to place the values, I figured under ingress would make sense, could argue for moving it to its own block if you wanted to.
We are using the virtual service and gateway at $JOB, works well for us.
https://github.com/reportportal/kubernetes/issues/274 is related in the same vein, a third ingress option. Depending on what we do in this PR, will make fixing that issue easier.
@Jmainguy Please check out my comments.
Thank you for feedback, will work on fixing up
Hei question,
What is the reason this PR got closed without mergin?
@GianniGiglio hi. You didn't answer on the comments a long time.
@raikbitters I wasn't involved in this ticket just bumped on it by accident and I was wondering if you guy's where planning to support istio ingress since I have a simular use case. :)
You have me confussed with someone else :)
@GianniGiglio sorry for the misunderstanding. We don't consider supporting Istio right now. However, you can suggest your solution via PR.