repology-webapp icon indicating copy to clipboard operation
repology-webapp copied to clipboard

Add dark theme

Open vitaly-zdanevich opened this issue 1 year ago • 15 comments

https://developer.mozilla.org/en-US/docs/Web/CSS/@media/prefers-color-scheme

vitaly-zdanevich avatar Mar 16 '23 20:03 vitaly-zdanevich

Can I implement this?

vitaly-zdanevich avatar Apr 25 '24 06:04 vitaly-zdanevich

Sure, but you've wanted to ask whether it would be accepted, and that depends on the solution. Do you have a plan? Does bootstrap support it?

AMDmi3 avatar Apr 25 '24 11:04 AMDmi3

I did not try with bootstrap, but I fount this - yes, looks like supported https://getbootstrap.com/docs/5.3/customize/color-modes/

vitaly-zdanevich avatar Apr 25 '24 15:04 vitaly-zdanevich

That says "Added in v5.3". Repology uses bootstrap 3.

AMDmi3 avatar Apr 25 '24 15:04 AMDmi3

Do you want to update the Bootstrap?

vitaly-zdanevich avatar Apr 25 '24 16:04 vitaly-zdanevich

...or what about to drop the Bootstrap? Why do we need it? UI is pretty simple. For the default colors/margins only?

vitaly-zdanevich avatar Apr 25 '24 16:04 vitaly-zdanevich

...or what about to drop the Bootstrap?

I would definitely prefer to drop bootstrap - new versions have introduced visual (as opposed to semantic) classes like spacing utilities which is not right.

For the default colors/margins only?

No, it's used for everything so dropping it won't be trivial. The replacement should me manageable (BEM preferred), responsive stylesheet, with no regressions in accessibility and other features.

AMDmi3 avatar Apr 26 '24 12:04 AMDmi3

Do you know some candidates?

vitaly-zdanevich avatar Apr 26 '24 23:04 vitaly-zdanevich

Which candidates?

AMDmi3 avatar Apr 27 '24 09:04 AMDmi3

To replace Bootstrap.

vitaly-zdanevich avatar Apr 27 '24 09:04 vitaly-zdanevich

No. My plans were to use completely custom CSS.

AMDmi3 avatar Apr 27 '24 09:04 AMDmi3

Hm, looks like its a lot of work, right?

vitaly-zdanevich avatar Apr 28 '24 04:04 vitaly-zdanevich

Exactly. But maybe it can be done gradually

AMDmi3 avatar Apr 28 '24 12:04 AMDmi3

So, how can I start?

vitaly-zdanevich avatar Jun 30 '24 20:06 vitaly-zdanevich

Sorry, I cannot offer any guidance here.

AMDmi3 avatar Jul 01 '24 11:07 AMDmi3