repman icon indicating copy to clipboard operation
repman copied to clipboard

Fix no stable release sorting bug

Open marickvantuil opened this issue 3 years ago • 1 comments

This fixes the issue in #562 where if the first fetched package is not stable, then no stable release can be determined because the version comparison will fail with Comparator::greaterThan.

marickvantuil avatar Sep 20 '22 12:09 marickvantuil

Not sure why the Buddy build is failing, let me know if I can do something to fix it. 👍

marickvantuil avatar Sep 20 '22 12:09 marickvantuil

This actually fixes the issue on my installation.

aleho avatar Jan 23 '23 18:01 aleho

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (b463a21) 99.04% compared to head (8373ebd) 99.04%.

:exclamation: Current head 8373ebd differs from pull request most recent head c5f25d4. Consider uploading reports for the commit c5f25d4 to get more accurate results

Additional details and impacted files
@@            Coverage Diff            @@
##             master     #617   +/-   ##
=========================================
  Coverage     99.04%   99.04%           
- Complexity     1910     1914    +4     
=========================================
  Files           301      301           
  Lines          6075     6079    +4     
=========================================
+ Hits           6017     6021    +4     
  Misses           58       58           
Impacted Files Coverage Δ
...ackageSynchronizer/ComposerPackageSynchronizer.php 97.08% <100.00%> (+0.08%) :arrow_up:

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

codecov[bot] avatar Apr 30 '23 05:04 codecov[bot]