repman icon indicating copy to clipboard operation
repman copied to clipboard

Allow to direct-add existing users to organization

Open nickygerritsen opened this issue 4 years ago • 4 comments

I was wondering whether it would be a useful feature to be able to add existing users to an organization directly. Currently the user always needs to accept an invite, even if a user already exist for the given email address.

We could do it in several ways:

  1. If you invite a user with an email address that already exists, immediately add the user and notify them using email instead of creating an invitation.
  2. Create a separate screen to add existing users, where you can get autocompletion. This might be a privacy issue, since you can then see information for all users, even ones who aren't in an organization you are also part of.
  3. Do the same as 2. but put it in the admin organizations page (on a detail page?)
  4. Create a command to add a user to an organization.

Is this something that would be useful? And if so, which option(s) would be best? I can certainly try to implement this.

nickygerritsen avatar Jul 13 '20 19:07 nickygerritsen

At the moment, the invitation causes a conscious join. This has been done intentionally so that the user can confirm that he wants to join. Most major suppliers do just that.

It also allows you to control what I attach as a user. It protects me from getting unwanted mail. Remember that group members receive email notifications (for now only with security vulnerabilities, but in the future there may be more).

Do you see anything wrong or impractical in accepting the invitation? Perhaps we could make this process more enjoyable or simpler?

akondas avatar Jul 14 '20 05:07 akondas

We want to use Repman internally at our (small-ish) company where we would like to add users to multiple organizations (we have one for each of our customers that has a composer dependency) which currently makes it that the user needs to accept every invitation. But I can also see why it would be better to actively ask the user if they want to join.

nickygerritsen avatar Jul 14 '20 05:07 nickygerritsen

If you care so much about it, we can do this feature, but it will be an additional option to configure in the instance settings (like "Local authentication"). Then you could do something like this: "Require confirmation of organization invitation", the default would be "yes". If such a thing suited you, I would see it as a separate command and only checking in the controller action whether this option is enabled: as so, dispatch of the old command, if not dispatch of the new.

akondas avatar Jul 14 '20 06:07 akondas

Shall we wait a bit and see if others are interested in this? If it's only me I'd say let's not clutter the project with it.

nickygerritsen avatar Jul 14 '20 06:07 nickygerritsen