Fix reloading asar addons without restarting Discord

[asportnoy]

Electron caches asar files, which causes issues if you try to replace or update an addon while Discord is running. Our only workaround is to fully quit and restart Discord, which isn't ideal. We need some way to clear the cache.

[bop34]

iirc electron caches asar files to memory

[colin273]

General solution: load addons with our own asar parsing instead of the automatic asar handling that Electron provides (use original-fs, available only in Electron, to access the unpatched version of Node's fs). The difference is that while Electron doesn't expose the asar cache, we have a bit more latitude if we reimplement asar loading.

Possible implementation approaches:

• Use @electron/asar in main to load asar addons. The downside is that this also includes code to generate asar archives from folders. That's bloat.
• Write our own barebones asar parser that supports the minimum features we need--read asar, cache files, clear cache.

In either case, it might be best to use a separate protocol for loading addons with our own asar handling. Our current protocol responds to queries with file paths; with our own asar handling, we would have to send raw data instead.

replugged.asar and Discord's stuff would continue to be loaded with Electron's default asar handling.

[bop34]

That's a pretty good idea. I'm willing to give it a shot, but I'm busy until Thursday. This would also close issue #373

[asportnoy]

Assigning to you for now

[yofukashino]

That's a pretty good idea. I'm willing to give it a shot, but I'm busy until Thursday. This would also close issue #373

just reading the issue for fun and damn Feb 20 2023... Its Christmas now :3 just saying you forgot i guess