polygott icon indicating copy to clipboard operation
polygott copied to clipboard

Image Build Fails on gapl language setup

Open SteveCastle opened this issue 4 years ago • 2 comments

Screen Shot 2020-10-14 at 4 08 55 PM

When building the image the build scripts call undup(line) in phase2.ejs while installing each language.

undup is a function in index.js that seems to comment out commands in the install array if they are already in the dc array in index.js. It seems like this means commands from previously installed languages would still be in that array including previous make and make install?

This causes the make and make install commands to be commented out, and the apl binary to fail to be created and copied, causing a crash.

I was going to make a PR but I realized I don't really understand the point of the dup check in the first place so I thought I'd just comment.

SteveCastle avatar Oct 14 '20 23:10 SteveCastle

I actually just removed the undup call from the ejs template to fix it for myself.

SteveCastle avatar Oct 14 '20 23:10 SteveCastle

Plus it seems like a PR has already been approved to remove the language. I think the issue I mentioned could still happen to other languages though.

SteveCastle avatar Oct 14 '20 23:10 SteveCastle