datahike icon indicating copy to clipboard operation
datahike copied to clipboard

db.clj refactoring

Open jsmassa opened this issue 2 years ago • 0 comments

jsmassa avatar Aug 04 '22 11:08 jsmassa

Closes #525

jsmassa avatar Aug 31 '22 13:08 jsmassa

Could you check if that works with the latest rebase as well?

kordano avatar Sep 02 '22 16:09 kordano

This looks good to me as well, but it is a bit difficult to see whether the functionality has changed somewhere or whether functions have just been pulled out to different namespaces. I think it is the latter and in this case everything should be fine.

It is a bit annoying that I have to rebase my two open PRs for the GraalVM support and the global address space again after this, but hopefully it won't cost me more than a few hours. Ideally we should settle PRs affecting functionality before doing refactorings like this and plan this a bit ahead to avoid such rebases.

whilo avatar Sep 02 '22 20:09 whilo