ship
ship copied to clipboard
replicatedhq
Apply Common app.kubernetes.io labels
Would be cool if ship could add common app labels like app.kubernetes.io/managed-by: ship, as described in https://kubernetes.io/docs/concepts/overview/working-with-objects/common-labels/
Probably something we could add in at the overlays/ship level? Not sure.
It would be nice if there was a 'generated-by' tag - I think that would fit what Ship does a bit better.
IMO 'managed-by' would be something like flux - the thing that actually delivers yaml to the cluster.
Not opposed to that. I think generated-by is in line with the sort of heritage: Tiller stuff that pops up in server-side or client-side helm-produced manifests.
@laverya I did some more looking around, and I think we should still consider including the standard managed-by tag. Kustomize team uses it in their example like so: https://github.com/pst/multi-cluster-multi-tenant-kustomize/blob/master/bases/app/kustomization.yaml#L1-L5
I think the problem with reusing the managed-by tag is that it might get overwritten by whatever system the end user is using to deploy to their cluster. Perhaps use both?