Empty `kind` and `apiVersion`

[yujunz]

Expected behavior

kind and apiVersion filled with correct values

Actual behavior

kind: ""
apiversion: ""
bases:
- ../../base

Information

• Ship version: ... { "version": "0.33.1", "buildTime": "2019-02-18T20:17:07Z" }
• Docker version: ...
• Command line run:

ship init https://raw.githubusercontent.com/kubernetes/dashboard/master/aio/deploy/recommended/kubernetes-dashboard.yaml

Steps to reproduce the behavior

1. ship init https://raw.githubusercontent.com/kubernetes/dashboard/master/aio/deploy/recommended/kubernetes-dashboard.yaml
2. cat overlays/ship/*

[dexhorthy]

Hi @yujunz thanks for submitting an issue -- I think maybe kind and apiVersion were added to kustomize in the 2.x branch, and we're still on 1.0.x (I think 1.0.11 but I'd have to check).

We'd like to get to Kustomize 2.x eventually, but this may end up being a breaking change to ship, so I'm going to create an issue for discussion of that transition.

[laverya]

We're currently on 2.0.2, we just aren't filling out apiVersion and kind - something we should be doing though!

https://github.com/replicatedhq/ship/blob/ce0e98ade7d08b76975cdc27ffe50b845590d908/Gopkg.toml#L90-L92

[dexhorthy]

Gotcha, missed that change -- thanks @laverya

[laverya]

I think that most of the change there will be test fixes - there's a lot of places where we expect that output. Most of our integration tests, for example... (the basic istio test is one of many)