ship icon indicating copy to clipboard operation
ship copied to clipboard

Unable to discard yaml files in a sub directory

Open justyns opened this issue 5 years ago • 1 comments

Expected behavior

When clicking the trash / discard icon in the web ui, it should discard the file whether it is in the root directory or a sub directory.

Actual behavior

If I load an upstream project with yaml files inside of a sub directory, I am unable to discard any files located in a subdirectory through the web ui.

I checked the debug log, as well as the browser's network/console log and it doesn't look like the browser ever sends a request to discard that file. There are no JS errors either.

I did try curl -X DELETE http://localhost:8800/api/v1/kustomize/base\?path\=/path/to/a/subdir/file.yaml and it returned success. I confirmed it is still discarded when I run ship update --headed a second time as well.

The api seems to work fine, but the ui probably isn't sending the request for some reason.

Information

  • Ship version: 0.33.1
  • Docker version: ...
  • Command line run:

Steps to reproduce the behavior

  1. ship init https://github.com/jenkinsci/kubernetes-operator/tree/v0.0.4/deploy (or any other repo with a subfolder inside of it)
  2. try to click the discard icon for a file in the crds/ sub directory

justyns avatar Feb 19 '19 21:02 justyns

No errors in the browser console, either - my guess is a logic error in the JS somewhere. Something to look into, thanks for reporting it!

laverya avatar Feb 19 '19 23:02 laverya