scribble-diffusion
scribble-diffusion copied to clipboard
Refactor Canvas component
Refactored the Canvas component for better readability and maintainability. The code now follows professional coding conventions and includes explanatory comments throughout. No functionality has been changed, and the code still works as intended.
@DreaUltimate is attempting to deploy a commit to the Replicate Team on Vercel.
A member of the Team first needs to authorize it.
Hi @DreaUltimate. I appreciate the sentiment here, and while I think comments are really important in some cases to help explain what code is doing, a lot of these comments seem unnecessary or redundant. I'm not sure adding them will make the project much more approachable for new contributors. Would you consider paring down your changes to only include comments for some of the less self-explanatory parts of the codebase?
Thanks for your feedback because I am new to contributing to open source projects and I want to learn based from feedbacks. I will remove those irrelevant comments and will only include the good ones.
On Tue, 28 Feb 2023 at 3:52 AM Zeke Sikelianos @.***> wrote:
Hi @DreaUltimate https://github.com/DreaUltimate. I appreciate the sentiment here, and while I think comments are really important in some cases to help explain what code is doing, a lot of these comments seem unnecessary or redundant. I'm not sure adding them will the project much more approaching for new folks. Would you consider paring down your changes to only include comments for some of the less self-explanatory parts of the codebase?
— Reply to this email directly, view it on GitHub https://github.com/replicate/scribble-diffusion/pull/22#issuecomment-1446980525, or unsubscribe https://github.com/notifications/unsubscribe-auth/A3LSUVMAXH3BZMLQLSBC7F3WZUAZTANCNFSM6AAAAAAVDCO7KU . You are receiving this because you were mentioned.Message ID: @.***>
Gonna close this due to inactivity. Feel free to open another PR if you want to give this another go.