scribble-diffusion icon indicating copy to clipboard operation
scribble-diffusion copied to clipboard

Published 20 hours ago • verified publisher icon replicate

Canvas doesn't work properly on Firefox / Android

Open dolmen opened this issue 2 years ago • 6 comments

I tried https://scribblediffusion.com/ on multiple devices (phone, tablet) with Mozilla Firefox, and drawing doesn't work properly:

  • the initial image is not fully rendered: it looks like the image is randomly cropped on the right and on the bottom
  • when drawing on a touch screen drawing doesn't follow the finger correctly. Well, sometimes it works, sometimes not.

dolmen avatar Feb 18 '23 18:02 dolmen

Thanks for reporting.

See also #15

zeke avatar Feb 19 '23 07:02 zeke

Hi,

If this result into being a Firefox bug in our canvas implementation, I would be happy to know more about it and see if we can get this fixed rapidly, don't hesitate to ping me if this is the case.

Regards Pascal Chevrel Firefox Release Manager

pascalchevrel avatar Feb 20 '23 11:02 pascalchevrel

Thanks @pascalchevrel

initial image is not fully rendered: it looks like the image is randomly cropped on the right and on the bottom

☝🏼 This part is definitely not a Firefox issue. See #15

Not sure about the touch screen drawing though.

zeke avatar Feb 20 '23 19:02 zeke

Hi! I don't think is a Firefox issue, I made this simple app a long time ago and is working fine on Firefox: https://draw-app.vercel.app (a sketch drawing example from scratch). It may be related to this issue https://github.com/vinothpandian/react-sketch-canvas/issues/114

If you're open to contributions, I may have a look at it later

After a bit of a search, this is the problem: https://github.com/vinothpandian/react-sketch-canvas/pull/112

Seems that the fix is only on the pre-release version of the library, updating react-sketch-canvas to the next tag fixes the issue

MrMarble avatar Feb 23 '23 10:02 MrMarble

Yeah this is the issue: https://github.com/vinothpandian/react-sketch-canvas/issues/54

The issue is marked as closed but I don't think it's actually fixed in the latest release of react-sketch-canvas:

https://www.loom.com/share/b804e56441d6494f96d24e83dd2634ed

zeke avatar Feb 28 '23 21:02 zeke

I have the same issue on firefox on windows and firefox for android. It's almost all white, and sometimes it displays half of the canvas image

softyoda avatar Mar 01 '23 11:03 softyoda

I think this was fixed by https://github.com/replicate/scribble-diffusion/issues/31

zeke avatar Apr 13 '23 16:04 zeke