keepsake icon indicating copy to clipboard operation
keepsake copied to clipboard

Add datetime type to param.Value

Open andreasjansson opened this issue 4 years ago • 3 comments

When filtering on creation time in replicate ls --filter "started >= 2020-11-12 we treat the time value 2020-11-12 as a string and then use a special case to convert started to a timestamp. It would be more robust to actually have a datetime param.Value type.

andreasjansson avatar Nov 12 '20 22:11 andreasjansson

@andreasjansson Can I take this up? I'm trying to get familiar with the go part of the codebase and learn go. It seems like a simple enough place to start.

gan3sh500 avatar Jan 05 '21 11:01 gan3sh500

@gan3sh500 Go for it! No need to ask permission, but probably worth commenting to say you're working on something. We'll assign issues to ourselves if we're working on them. :)

You might want to base on top of #408, or at least be aware of the changes in case they collide with yours.

bfirsh avatar Jan 05 '21 16:01 bfirsh

@bfirsh Okay. Just checking if anyone else was working on it. I'll take a look at #408 first.

gan3sh500 avatar Jan 05 '21 23:01 gan3sh500