cog icon indicating copy to clipboard operation
cog copied to clipboard

Published 20 hours ago • verified publisher icon replicate

Revert "Remove NVIDIA apt sources/key"

Open bfirsh opened this issue 3 years ago • 2 comments
trafficstars

This reverts commit 67c5b31a143d6601df58ddd705bd707680359d6b.

#579 removed the nvidia apt sources because they were broken upstream. When CI passes here, they have been fixed and we can merge this.

See also https://github.com/NVIDIA/nvidia-docker/issues/1631

bfirsh avatar May 02 '22 15:05 bfirsh

Seeing if the tests pass again...

bfirsh avatar May 16 '22 23:05 bfirsh

Tests pass now but judging by https://github.com/NVIDIA/nvidia-container-toolkit/issues/258 it still seems to be an issue for some base images. Maybe the tests are running on one which happens to work for now.

Leaving this as a draft out of caution, and let's maybe merge this when that nvidia issue is resolved.

bfirsh avatar May 16 '22 23:05 bfirsh

@bfirsh should we get this in now? It looks like the linked issue has been pretty quiet for a good long while.

evilstreak avatar Jan 03 '23 14:01 evilstreak

Yeah I suppose so? I have rebased on main.

bfirsh avatar Jan 04 '23 00:01 bfirsh

I reckon let's get this in and we can always revert if there are errors.

bfirsh avatar Feb 07 '23 20:02 bfirsh