reor icon indicating copy to clipboard operation
reor copied to clipboard

Container build

Open rpdelaney opened this issue 6 months ago • 3 comments

Would you accept a pull request with a Containerfile for running the app with podman or docker?

rpdelaney avatar Feb 16 '24 15:02 rpdelaney

Absolutely, that'd be great to see!

samlhuillier avatar Feb 16 '24 15:02 samlhuillier

Can I ask why we .gitignore the package-lock.json file? My understanding is that having a lock file is necessary to ensure the builds are reproducible.

rpdelaney avatar Feb 16 '24 22:02 rpdelaney

Yes of course. My apologies for this - so much time solo deving this project has led to things like this slipping through! Could you add the package-lock.json as part of a PR?

samlhuillier avatar Feb 17 '24 11:02 samlhuillier

Any update on this @rpdelaney ?

samlhuillier avatar Feb 26 '24 14:02 samlhuillier

Nope. Are you blocked on something or just excited? :)

rpdelaney avatar Feb 26 '24 19:02 rpdelaney

Just excited!

samlhuillier avatar Feb 28 '24 01:02 samlhuillier

I'm a bit confounded by needing to install runtime dependencies for Electron even when using their base images. Perhaps this is my inexperience with the ecosystem showing. Here's where I am now:

$ podman run --rm localhost/reor:latest

> [email protected] dev
> vite


  VITE v4.5.2  ready in 368 ms

  ➜  Local:   http://localhost:5173/
  ➜  Network: use --host to expose
vite v4.5.2 building for development...

watching for file changes...
vite v4.5.2 building for development...

watching for file changes...

build started...

build started...
transforming...
transforming...
✓ 1 modules transformed.
rendering chunks...
computing gzip size...
dist-electron/preload/index.js  20.92 kB │ gzip: 6.12 kB │ map: 11.96 kB
built in 141ms.
✓ 108 modules transformed.
rendering chunks...
computing gzip size...
dist-electron/main/index.js  316.34 kB │ gzip: 61.50 kB │ map: 641.20 kB
built in 720ms.
/usr/src/app/node_modules/electron/dist/electron: error while loading shared libraries: libgbm.so.1: cannot open shared object file: No such file or directory

It has been many times I added things to lines 6-16 and I am tired. Once that is done next step would be to optimize the final image size. It's my gift to you or anyone else who might want to take it from there before I get a second wind 😓

Edit: Now that I wrote all that out I think I see the problem.

rpdelaney avatar Feb 28 '24 21:02 rpdelaney