reor icon indicating copy to clipboard operation
reor copied to clipboard

Improve the context controls for chat window

Open samlhuillier opened this issue 1 year ago • 15 comments

Problem

Currently to customise context retrieval settings in each chat, the user has to go into a messy modal to customise each chat which does not make it easy to chat.

Video shows current experience:

https://github.com/user-attachments/assets/f029a1e5-7596-4a4b-88f1-ba1f3bf75282

Solution

All the controls in the modal should be moved to a titlebar section immediately visible when a user opens a new chat:

  • The titlebar should allow the user to see the current setting for each of number of context items, date filters and files that have been added to context.
  • And clicking on each of these should open a mini popup/tooltip to customise the setting.

The titlebar should either be at the top of the chat window or at the bottom just above the chat input field. It should also disappear as soon as the first chat message is submitted.

See src/components/Chat/Chat.tsx to get started. Feel free to comment below with questions or other ideas šŸ˜€

samlhuillier avatar Aug 12 '24 21:08 samlhuillier

Hey There! I am trying to setup the repo locally to solve this issue but I am running into LanceDB Error on Windows. Even after referring the docs the error still persists. I was wondering if you could help.

Manas-Kenge avatar Aug 13 '24 17:08 Manas-Kenge

Hi @samlhuillier, I see that there's some interest in this issue, but it's not currently assigned to anyone. I've started looking into this issue and currently planning on how to resolve it. I’d love to help out with it. Is it okay if I work on this? Thanks!

sarthakladhwe avatar Aug 14 '24 03:08 sarthakladhwe

Hi @samlhuillier, I see that there's some interest in this issue, but it's not currently assigned to anyone. I've started looking into this issue and currently planning on how to resolve it. I’d love to help out with it. Is it okay if I work on this? Thanks!

Anyone can work on this issue, you don't need to be assigned to work on it.

weilirs avatar Aug 15 '24 01:08 weilirs

Hey There! I am trying to setup the repo locally to solve this issue but I am running into LanceDB Error on Windows. Even after referring the docs the error still persists. I was wondering if you could help.

You can open an issue and post more details.

weilirs avatar Aug 15 '24 01:08 weilirs

It's best if we don't duplicate work! And there's plenty of other cool things to work on!

@Manas-Kenge & @sarthakladhwe could you each confirm if you want to/have started working on this issue?

Also @Manas-Kenge what error message are you seeing with lance db?

samlhuillier avatar Aug 16 '24 17:08 samlhuillier

/bounty $60

joseplayero avatar Aug 16 '24 19:08 joseplayero

Hi @samlhuillier, I'm working on it. I shall create a pull request soon.

My approach is to position the context settings just above the chat input field. I believe this placement offers better accessibility and visibility for users. Additionally, instead of using popups or tooltips for changing the settings, I suggest integrating the settings directly into the titlebar for a more streamlined and intuitive user experience. I will provide screenshots to illustrate this idea soon. However, if it is preferred to have a popup/tooltip, I am happy to implement that as well.

sarthakladhwe avatar Aug 17 '24 06:08 sarthakladhwe

/attempt #345

Options

sarthakladhwe avatar Aug 17 '24 06:08 sarthakladhwe

@sarthakladhwe this approach sounds reasonable to me. as long as all the same settings in the modal can be edited in a nice intuitive ui + a couple of extra settings like llm (and more in the future) then please get started on a PR :)

joseplayero avatar Aug 17 '24 10:08 joseplayero

Hi @samlhuillier @joseplayero, I have linked a draft pull request for this issue. I would love some thoughts on the current approach. Any changes are welcome! :)

sarthakladhwe avatar Aug 19 '24 12:08 sarthakladhwe

/attempt #345

Algora profile Completed bounties Tech Active attempts Options
@onyedikachi-david 5 bounties from 2 projects
JavaScript, Shell
Cancel attempt

Just queuing up šŸ™‚

onyedikachi-david avatar Aug 28 '24 12:08 onyedikachi-david

feel free to attack the issue @onyedikachi-david i've re-assigned you to the task!

joseplayero avatar Aug 29 '24 20:08 joseplayero

@joseplayero /attempt #345

Algora profile Completed bounties Tech Active attempts Options
@aybanda 1 bounty from 1 project
Cancel attempt

aybanda avatar Sep 06 '24 13:09 aybanda

i will be taking on this task. apologies to all those who wanted to contribute, this requires some thought and extra refactoring. there will be more issues with bounties very soon :)

joseplayero avatar Sep 07 '24 11:09 joseplayero

Where are these controls in v0.2.31? I can't find them in either location image

alexbhandari avatar Nov 28 '24 16:11 alexbhandari