validity icon indicating copy to clipboard operation
validity copied to clipboard

Wrong type of message

Open chefranov opened this issue 3 years ago • 12 comments

When I check my page I got errors in the extension:

image

But if I check it on w3c validator site I got "Info" (not error).

image

Can you change type of message from Error to Info?

UPD: PR with fixes - #81

chefranov avatar Oct 13 '22 09:10 chefranov

+1 essential I would be happy too 🙏

peter-neumann-dev avatar Oct 14 '22 09:10 peter-neumann-dev

I think @renyard no longer supports this extension :(

chefranov avatar Nov 01 '22 11:11 chefranov

It seems so, unfortunately, I don't know a solution to fix that myself.

peter-neumann-dev avatar Nov 01 '22 11:11 peter-neumann-dev

It's easy to fix, but then need to build and use this extension only locally (not from store)

chefranov avatar Nov 01 '22 12:11 chefranov

Thanks for reporting this. The extension is not under active development, but I’m happy to release bug fixes.

It was the intention to take the log level into account and I’m pretty sure this used to work. I’ve not had a chance to dig into it, so I’m not sure why that’s not working anymore. @chefranov If you have a fix, please do raise a PR and I will test and release to the store as soon as I can.

renyard avatar Nov 01 '22 12:11 renyard

@renyard check PR please - #81

chefranov avatar Nov 01 '22 18:11 chefranov

In Chrome by default you can't see Info messages. If want to see it you need to mark Info from dropdown.

image

chefranov avatar Nov 01 '22 18:11 chefranov

@renyard did you get a chance to check PR?

chefranov avatar Nov 02 '22 12:11 chefranov

@chefranov Looks good from the PR, thanks for submitting it. I’ve not had a chance to test and build it for release yet though. I hope to get some time to sort that out over the weekend. I’ll update here once it’s been released to the store.

renyard avatar Nov 04 '22 16:11 renyard

I've just landed the PR and submitted to the Chrome Web Store. All going well, it should start rolling out to users once it's been approved in the next couple of days.

@chefranov Thanks again for submitting this PR, it's much appreciated by myself and Validity users. 🎉

I'll leave this ticket open until we've confirmed that it's been released to the store.

renyard avatar Nov 06 '22 17:11 renyard

Appeared in the store. For me works fine. @peter-neumann-dev can you check from your side?

chefranov avatar Nov 07 '22 09:11 chefranov

@chefranov Yes, it's working fine! Thank you, both 👏

peter-neumann-dev avatar Nov 07 '22 09:11 peter-neumann-dev