applications-setup-guide icon indicating copy to clipboard operation
applications-setup-guide copied to clipboard
verified publisher icon renuo

Only not risky autofixes

Open schmijos opened this issue 1 year ago • 3 comments

Risky autofixes shouldn't be needed, I guess.

schmijos avatar Sep 25 '24 10:09 schmijos

But they have a very limited ruleset. We may break things because we use way more rules.

schmijos avatar Oct 01 '24 14:10 schmijos

And it's not default anymore: https://github.com/rails/rails/pull/51782/files

schmijos avatar Oct 01 '24 15:10 schmijos

Let's see: https://github.com/rails/rails/pull/53138

schmijos avatar Oct 01 '24 15:10 schmijos

I think this can be entirely removed anyway. Rails does it.

coorasse avatar Oct 08 '24 09:10 coorasse

I added some more people, so that we can come to a conclusion on this PR.

coorasse avatar Jan 30 '25 12:01 coorasse

I have enough code coverage everywhere to catch bugs.

It's not about your code though but about generated code for a new project, which may subtly fail.

rnestler avatar Jan 31 '25 09:01 rnestler

Let me conclude:

  • We disagree with the change here, so I'm closing this.
  • We would agree with the change in https://github.com/rails/rails/pull/53138. But this has been closed by the maintainer.

schmijos avatar Feb 07 '25 07:02 schmijos