mogenerator icon indicating copy to clipboard operation
mogenerator copied to clipboard

Updates the Objective-C templates

Open DaveWoodCom opened this issue 8 years ago • 2 comments

Summary of Changes

Fixes some syntax errors in the templates introduced in https://github.com/rentzsch/mogenerator/commit/5fb42293d7f471f3eee80047cb4f53f896b99f47 Prevents creating primativeValue methods that triggers Apple's piss-poor private-API-use detector when submitting to the App Store

Addresses

Similar to #74 and #16 May also want to update mogenerator.m in a similar way to: https://github.com/rentzsch/mogenerator/commit/cd9809de0ec266995069c4350feb0bf78ebc6795 If you'd prefer that, let me know and I can submit a new PR.

DaveWoodCom avatar Sep 11 '16 05:09 DaveWoodCom

Hey Dave,

That syntax error is embarrassing! Thanks for pointing out a flaw in my test coverage. I just added that coverage, produced the failure, cherry-picked your patch and things are working now.

Yes, I'd prefer to work-around primativeValue the same way primativeType is handled. If you could issue another Pull Request with that, that would be awesome. Be sure to base it off master since noninheritedAttributesSansType changed since https://github.com/rentzsch/mogenerator/commit/cd9809de0ec266995069c4350feb0bf78ebc6795 to print a warning (and should print a warning for primativeValue suppression as well).

rentzsch avatar Sep 14 '16 18:09 rentzsch

Hey @DaveWoodCom and @rentzsch, it looks like at least some of this PR was covered in commit b8d4687fef07bc92761c11ba7950e59ae404981b. Does this PR address anything still outstanding? I don't want to close it if it does but I don't want to leave it open if it's no longer needed.

atomicbird avatar Jul 22 '18 23:07 atomicbird