koila icon indicating copy to clipboard operation
koila copied to clipboard

Compatibility with python 3.7?

Open nbroad1881 opened this issue 2 years ago • 7 comments

I'm wondering what makes it incompatible with python 3.7 because that is the python version I am using and I can't upgrade to 3.8

nbroad1881 avatar Nov 30 '21 16:11 nbroad1881

Personally I use the walrus operator := a lot and it's only supported in 3.8 or above. I guess I just didn't use 3.7 on local when developing this project.

However, supporting 3.7 would be a great idea, as PyTorch itself supports 3.6, 3.7, 3.8. So I'll be working on it when I've got time.

rentruewang avatar Nov 30 '21 17:11 rentruewang

Is there anything besides the walrus operator that makes it incompatible with 3.7?

nbroad1881 avatar Nov 30 '21 18:11 nbroad1881

There is a @final decorator that isn't available in 3.7. Other than that and walrus operator, it should be compatible with 3.7.

rentruewang avatar Nov 30 '21 18:11 rentruewang

Protocol in typing is also 3.8

nbroad1881 avatar Dec 01 '21 01:12 nbroad1881

Oh, I didn't know that. Thanks!

rentruewang avatar Dec 01 '21 03:12 rentruewang

This would be great - colab also runs on Python 3.7 and I could imagine that many people would like to use koila there

nielsrolf avatar Dec 08 '21 01:12 nielsrolf

I agree. As who use colab / kaggle notebooks, it's sad that I can't use Koila cuz they use Python 3.7 :( Making it compatible with 3.7 would potentially have more people use your package. I just posted the issue that pip can't find Koila on colab / kaggle, but is it because of the version incompatibility?

lukeleeai avatar Dec 20 '21 12:12 lukeleeai